Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add CJS & ESM build #23

Merged
merged 3 commits into from
Mar 26, 2019
Merged

build: add CJS & ESM build #23

merged 3 commits into from
Mar 26, 2019

Conversation

ambar
Copy link
Collaborator

@ambar ambar commented Mar 25, 2019

  • 每个包都需要输出 CJS
  • 部分包没有经过 build
  • 去掉多余的 @babel/runtime

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   53.32%   53.32%           
=======================================
  Files         123      123           
  Lines        1652     1652           
=======================================
  Hits          881      881           
  Misses        771      771

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651c7d0...709d983. Read the comment docs.

@wangcheng
Copy link
Contributor

之前试过 rollup,发现体积区别很大,用 source-map-explorer 看了一下,发现没有把 hls.js 打包进去。

@ambar
Copy link
Collaborator Author

ambar commented Mar 25, 2019

@wangcheng678 看起来 Rollup 没有处理那个条件表达式,撤消了那部分,还是先用 webpack 吧。

@wangcheng wangcheng closed this Mar 25, 2019
@wangcheng wangcheng reopened this Mar 25, 2019
@xiaoyuhen xiaoyuhen merged commit cddf8a3 into zhihu:master Mar 26, 2019
@ambar ambar deleted the build branch September 13, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants